-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CDK/TypeScript folder which contains CDKv2 code. #230
Added CDK/TypeScript folder which contains CDKv2 code. #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🙏
I've left a few comments to address :)
@alexcasalboni I have updated the the-lambda-power-tuner.test.ts file. It was not reflecting CDKv2, updated and tested the new code and it works fine now. Also I have removed README.md file. Will review the other changes suggested and push a new commit later. |
…bda-power-tuner-stack.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few comments to address :)
…ll CloudFormation parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we're ready to merge this 🚀
Added CDK/TypeScript folder which contains CDKv2 code to provision lambda power tuner.